Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update a word in islands.mdx #11015

Merged
merged 1 commit into from
Feb 21, 2025
Merged

fix: update a word in islands.mdx #11015

merged 1 commit into from
Feb 21, 2025

Conversation

jsparkdev
Copy link
Contributor

Description (required)

The avatar is located in the header, not the heading, so I fix it.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Feb 21, 2025 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/concepts/islands.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@netlify Netlify
Copy link

netlify bot commented Feb 21, 2025 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 35d7115
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67b82a380ba1ca00088b4a0e
😎 Deploy Preview https://deploy-preview-11015--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ArmandPhilippot
ArmandPhilippot approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll just update the title because we want a change in Lunaria status since some translations also need to be updated. (typo in the title prevent the status change)

@ArmandPhilippot ArmandPhilippot changed the title fix: update typo in islands.mdx fix: update a word in islands.mdx Feb 21, 2025
@ArmandPhilippot ArmandPhilippot added the typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text. label Feb 21, 2025
@ArmandPhilippot ArmandPhilippot merged commit e364ae6 into withastro:main Feb 21, 2025
11 checks passed
@jsparkdev jsparkdev deleted the fix-island branch February 21, 2025 11:33
@jsparkdev
Copy link
Contributor Author

@ArmandPhilippot

thank you!

@jsparkdev jsparkdev mentioned this pull request Feb 21, 2025
Merged
@ArmandPhilippot
Copy link
Member

Well, it seems I should have reword the commit as well... the status change has not been triggered. 😅 Fortunately, it seems that the change only concerns ko-KR, fr and zh-cn...

@jsparkdev
Copy link
Contributor Author

Actually, I'm glad it's not a big impact update lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArmandPhilippot ArmandPhilippot ArmandPhilippot approved these changes

Assignees
No one assigned
Labels
typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsparkdev @astrobot-houston @ArmandPhilippot